Skip to content

Commit

Permalink
Fixed bug where saved hander names were not being re-used
Browse files Browse the repository at this point in the history
When loading up the rename dialog with previously used settings from a
pre-saved handler, the name wouldn't populate. This could be confusing.
Turns out I was doing extra work that caused the comparison to always
fail.
  • Loading branch information
Laharah committed Apr 29, 2020
1 parent 3ce65fc commit 7643c5f
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions filebottool/gtkui/rename_dialog.py
Expand Up @@ -335,12 +335,24 @@ def on_execute_filebot_clicked(self, button):

handler_name = self.glade.get_widget(
'saved_handlers_combo').get_child().get_text()
if not handler_settings['query_override']:
handler_settings['query_override'] = None
log.debug('got %s for handler name in from combobox', handler_name)
if (handler_name in self.saved_handlers
and handler_settings == self.saved_handlers[handler_name]):
log.debug('handler matches saved handler, setting name to %s.', handler_name)

handler_settings['handler_name'] = handler_name
else:
log.debug('handler "%s" did not match saved handler. Setting to None.',
handler_name)
# new, saved = set(list(handler_settings.keys())), set(list(handler_settings.keys()))
# missing = new ^ saved
# if missing:
# log.debug('Key mismatch: %s.', missing)
# shared = new & saved
# for k in shared:
# new, saved = handler_settings[k], self.saved_handlers[handler_name][k]
# if new != saved:
# log.debug('mismatch on key "%s": %s != %s', k, new, saved)
handler_settings['handler_name'] = None

log.info("Sending execute request to server for torrents {0}".format(
Expand Down

0 comments on commit 7643c5f

Please sign in to comment.