BUG degrees mixed with radians in random draws #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that degrees is being mixed with radians in the random draws function?
I think this has been a silent bug since numerically degrees are always larger.
However, I wonder if this increases efficiency?
Also, now that this unit has changed, there appears to be a
sin(theta)
factor missing for the draws inphi
.And there is no reason to multiply and divide by 1.0.