More configurable TXTwoPointFourier #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly on POS-POS so far). Computation of theory c_ell now also optional.
…easily applied globally.
…ing for masks that are not binary.
…sent in config file
…xample config file
elvinpoole
reviewed
Apr 10, 2024
|
Thanks a lot Tom. This looks good to me. Just a couple of questions/comments. |
|
Thanks for the comments @anicola. For some reason they're not showing up here but I saw them via email and have now replaced the hard-coded values in question with the user-provided ell_min and ell_max. |
elvinpoole
approved these changes
May 14, 2024
anicola
approved these changes
May 15, 2024
txpipe/twopoint_fourier.py
Outdated
| smooth=True, | ||
| ell_values=theory_ell | ||
| ) | ||
| theory_ell = np.unique(np.geomspace(1, 3000, 100).astype(int)) |
There was a problem hiding this comment.
Might it be safer to determine lmax based on the ell range specified to compute the spectra instead of having hard-coded values?
| print(f"Loaded {nbin_source} lensing weight maps") | ||
|
|
||
| # Using a flat mask as the clustering weight for now, since I need to know | ||
| # how to turn the depth map into a weight |
There was a problem hiding this comment.
Is this comment still valid?
| if self.rank == 0: | ||
| print("Loaded mask") | ||
|
|
||
| cl_guess = nmt.compute_coupled_cell(field_i, field_j) / np.mean(mask * mask) |
There was a problem hiding this comment.
Why do you calculate cl_guess in this way? Also, as far as I understand it, the previously computed theory cls are never used for computing the deprojection bias. Or am I wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now specify which components of 3x2pt analysis to run in TXTwoPointFourier. Computation of the theory power spectra has also been made optional. Certain inputs (fiducial_cosmology, source_noise_maps, lens_noise_maps, density_maps, source_maps) are now also optional depending on which analyses the user wants to run.
Treatment of the survey mask has also been modified to account for cases where the mask is not binary. Users can now also specify a global config parameter, "mask_threshold", so that whenever the mask is read all pixels less than or equal to this value are automatically set to zero.
Tested with example 'metacal' and 'metadetect' pipelines, using all possible combinations of POS-POS, SHEAR-POS and SHEAR-SHEAR.