Skip to content

Commit

Permalink
Bump version to 1.2.0-rc8
Browse files Browse the repository at this point in the history
  • Loading branch information
@PhysSong
PhysSong committed Feb 19, 2019
1 parent 97e738a commit 55eb831
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Expand Up @@ -30,7 +30,7 @@ SET(PROJECT_COPYRIGHT "2008-${PROJECT_YEAR} ${PROJECT_AUTHOR}")
SET(VERSION_MAJOR "1")
SET(VERSION_MINOR "2")
SET(VERSION_RELEASE "0")
SET(VERSION_STAGE "rc7")
SET(VERSION_STAGE "rc8")
SET(VERSION_BUILD "0")
SET(VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_RELEASE}")
IF(VERSION_STAGE)
Expand Down

8 comments on commit 55eb831

@tresf
Copy link
Member

@tresf tresf commented on 55eb831 Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasp00 why is your artifact labeled lmms_1.2.0.rc7.1.tar.xz? This should be lmms_1.2.0.rc8.tar.xz.

@PhysSong
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tresf I guess it's due to

lmms/debian/changelog

Line 1 in 18d4787

lmms (1.2.0~rc7.1) unstable; urgency=low

@jasp00
Copy link
Member

@jasp00 jasp00 commented on 55eb831 Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhysSong, exactly.

@tresf
Copy link
Member

@tresf tresf commented on 55eb831 Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This puts an unnecessary burden on the LMMS developers to maintain a platform-specific versioning. Please advise. Also, please bump, build and upload so that our artifacts are accurate.

@jasp00
Copy link
Member

@jasp00 jasp00 commented on 55eb831 Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preparing source was the purpose of #4758. So, that decision should apply:

  1. Wait for an external maintenance task.
  2. For stable-1.2, update manually.

@tresf
Copy link
Member

@tresf tresf commented on 55eb831 Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasp00 I don't see how that applies. This is detailed release information maintained by a human. An automated task doesn't seem like it'll fix that problem.

@jasp00
Copy link
Member

@jasp00 jasp00 commented on 55eb831 Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wait for the task, it will fix the problem.

Another option is to prepare the source in the Travis build, but this option was discarded. Should this be reconsidered?

@tresf
Copy link
Member

@tresf tresf commented on 55eb831 Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever. You've created a problem that makes incorrectly versioned tarballs in our downloads area. Please fix the tarball. The maintenance tasks were broken. Travis is the wrong place (cmake would be OK, then Travis can pick it up) but I'm sick of arguing. You've placed hardcoded version into our project so you get to maintain it.

Please sign in to comment.