Enable Fortran interface for 32-bit sunindextype #447
Conversation
balos1
requested review from
gardner48,
cswoodward and
drreynolds
as code owners
…an-32index-buildma
|
@drreynolds @gardner48 All checks are green, yay! I think this is ready now. |
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
| find_package(KLU CONFIG) | ||
| find_package(SuiteSparse_config CONFIG) |
There was a problem hiding this comment.
While I tried using a newer KLU these other dependencies got picked up by the KLU target, did you have issues with it not finding them? I think I did have to up date the CMAKE_MODULE_PATH though rather than just setting KLU_ROOT or KLU_DIR.
There was a problem hiding this comment.
Right, if you set CMAKE_MODULE_PATH it will find them, but if you don't you need these other lines.
There was a problem hiding this comment.
Could you please show in which case you need to add these lines? It definitely wasn't intended that downstream projects would need to manually include dependencies of a SuiteSparse library.
Is this an issue with the CMake Config files installed by SuiteSparse?
There was a problem hiding this comment.
@mmuetzel The issue seems to be with using -DKLU_DIR=<suite_sparse_install_path>/lib64/cmake/KLU alone to provide the config file location. Using either -DKLU_ROOT=<suite_sparse_install_path> or -DCMAKE_PREFIX_PATH=<suite_sparse_install_path> works without the above additions.
@balos1 are you also setting -D<dependency>_DIR variables for the other packages? Using -DKLU_DIR alone didn't work for me with the above additions. I had add -D<dependency>_DIR variables for each dependency which also makes the config work without the above additions.
This issue is tangential to the topic of this PR so I suggest these changes get broken out into a separate PR.
examples/nvector/mpimanyvector/test_fnvector_mpimanyvector_mod.f90
Outdated
Show resolved
Hide resolved
Co-authored-by: David Gardner <gardner48@llnl.gov>
|
@gardner48 I think this is ready to merge, if you approve. |
| find_package(KLU CONFIG) | ||
| find_package(SuiteSparse_config CONFIG) |
There was a problem hiding this comment.
@mmuetzel The issue seems to be with using -DKLU_DIR=<suite_sparse_install_path>/lib64/cmake/KLU alone to provide the config file location. Using either -DKLU_ROOT=<suite_sparse_install_path> or -DCMAKE_PREFIX_PATH=<suite_sparse_install_path> works without the above additions.
@balos1 are you also setting -D<dependency>_DIR variables for the other packages? Using -DKLU_DIR alone didn't work for me with the above additions. I had add -D<dependency>_DIR variables for each dependency which also makes the config work without the above additions.
This issue is tangential to the topic of this PR so I suggest these changes get broken out into a separate PR.
This tweaks the SWIG generation, and CMake build system to support the Fortran interfaces for 32-bit or 64-bit sunindextype as suggested in https://github.com/LLNL/sundials-private/issues/60. Most of the files 'changed' are just the moved or new SWIG generated files. Unfortunately this does make the repository larger in terms of files and bytes.