More efficient calculation of axial currents #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l to remove DeprecationWarning when running tests
espenhgn
approved these changes
Feb 15, 2024
|
Looks good to me! Before merging, can you bump the version file so we can make available a new tag/release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459.
The calculation of axial currents from membrane potentials is very slow, and I found that most of the time was spent on recalculating the ''children_dict" and "connection_dict" for each segment, which is unnecessary since these do not change.
This PR moves the calculation of ''children_dict" and "connection_dict" outside the loop. All tests pass locally, and I get identical answers as before for a Hay model example. Importantly, the execution time went from 13 seconds to 0.4 seconds.