Modification to add ROISummedADC and HitSummedADC

[amerega]

Commit related to the LArSoft meeting
https://indico.fnal.gov/event/64331/
This commit is related to 3 parallel requests in: larreco, lardata and lardataobj

!! For the experts please have a look at line 223 of test/RecoBase/Hit_test.cc

[knoepfel]

code-checks

[SFBayLaser]

I am nervous about changing the name from "HitSummedADC" to "ROISummedADC" since so much analysis code (including private code not in repositories that could be updated easily) used the current name. I should also point out that it is not the sum over the input ROI necessarily, but is the sum over ADC values in a "snippet" which can be a subset of an ROI.

[amerega]

Just to be clear HitSummedADC was not moved to ROISummedADC. - SummedADC was transformed into ROISummedADC - HitSummedADC was added as new variable I thought that that was agreed on at the latest larsoft meeting. Regards Anselmo Il giorno 22 apr 2024, alle ore 18:40, Tracy Usher ***@***.***> ha scritto: I am nervous about changing the name from "HitSummedADC" to "ROISummedADC" since so much analysis code (including private code not in repositories that could be updated easily) used the current name. I should also point out that it is not the sum over the input ROI necessarily, but is the sum over ADC values in a "snippet" which can be a subset of an ROI. — Reply to this email directly, view it on GitHub<#42 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BH4X4YJHCXPRH324PMRG7TTY6U4RPAVCNFSM6AAAAABGS5PNKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZQGE3TGNRUGM>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[lgarren]

code-checks

[FNALbuild]

A new Pull Request was created by @amerega for develop.

It involves the following packages:

lardataobj

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  lardataobj/RecoBase/Hit.cxx \ 
  lardataobj/RecoBase/Hit.h \ 
  test/RecoBase/Hit_test.cc

Then commit the changes and push them to your PR branch.

[lgarren]

@amerega please fix the code formatting as requested on these 3 PRs.

[FNALbuild]

Pull request #42 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks