Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for 64 bits #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update for 64 bits #38

wants to merge 3 commits into from

Conversation

bottiger1
Copy link

@bottiger1 bottiger1 commented May 7, 2024

probably broke buildbot with this due to ambuild issues. can't run hl2sdk_manifest script outside of source dir nor can you make a symlink outside of it so I made the symlink in a bash script.

do what you will with this

@C0deSlasher
Copy link

I would test this if I could, but I need the Windows version of the extension. I tried building it myself (which is really hard to do because there are no instructions on how to build it), but AMBuild is refusing to cooperate and is complaining of errors in swgsdetours.cpp:

swgsdetours.cpp
C:[path]\steamworks-x64\Extension\swgsdetours.cpp(38): error C2065: 'SteamGameServer_InitSafeDetour': undeclared identifier
C:[path]\steamworks-x64\Extension\swgsdetours.cpp(38): error C2062: type 'bool' unexpected
C:[path]\steamworks-x64\Extension\swgsdetours.cpp(39): error C2143: syntax error: missing ';' before '{'
C:[path]\steamworks-x64\Extension\swgsdetours.cpp(39): error C2447: '{': missing function header (old-style formal list?)
C:[path]\steamworks-x64\Extension\swgsdetours.cpp(100): error C2065: 'SteamGameServer_InitSafeDetour': undeclared identifier
C:[path]\steamworks-x64\Extension\swgsdetours.cpp(100): error C2065: 'SteamGameServer_InitSafeDetour_Actual': undeclared identifier

@bottiger1
Copy link
Author

I'm not willing to spend much of my time on the windows version given that I don't have a windows build environment set up, and the lack of other people working on 64 bits is sucking up most of my time.

Your error indicates there is something wrong with your DETOUR_DECL_STATIC6 macro. Either it's missing or corrupted or your compiler is out of date.

@C0deSlasher
Copy link

The DETOUR_DECL_STATIC6 macro from swgsdetours.cpp is the same as yours. It came from your fork.

I am trying to use Visual Studio Community 2022 as the C++ compiler.

@bottiger1
Copy link
Author

I'm sorry but I cannot offer you any more support on this. My fork doesn't have the macro, it comes from sourcemod.

@C0deSlasher
Copy link

C0deSlasher commented May 19, 2024

Sorry, you are right, that does come from SourceMod. The point that I am trying to make is that something is preventing me from building this. Other Windows users may need help with this as well if you or someone else does not build it for them.

Also of interest is that I am using the version of SourceMod that your .yml work file is recommending: 1.7. How are you making this work with such an old version of SourceMod?

@C0deSlasher
Copy link

C0deSlasher commented May 31, 2024

I was able to get your previous version to build using Visual Studio 2015, hl2sdk-sdk2013, SourceMod 1.12 (not 1.7 like .github\workflows\c-cpp.yml suggested, which is what caused the problems earlier), MetaMod 2.0 (not 1.10), and a version of the Steamworks SDK that I found on here from someone. However, it resulted in a 32-bit extension instead of a 64-bit extension, and any attempt to force Visual Studio 2015 to make a 64-bit extension failed. Funny how something as simple as adding "--target x86_64" allowed for the x86 x64 cross tools compiler to initialize configure.py with your newest version, but now, it looks like you added some extra requirements, as ambuild is now complaining of missing "Zydis.c".

I know that you do not have much time, but I am determined to make this work. Hopefully, if we can come up with a solution, other Windows users may benefit from it.

Would you be willing to at least tell me what dependencies, dependency versions, and compiler you are using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants