Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: android blurview library updated #598

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dopplerDistortion
Copy link

Android BlurView library updated with @stemyke's PR Dimezis/BlurView#201

closes #511

@stemyke
Copy link

stemyke commented Oct 6, 2023

@dopplerDistortion Hey! Awesome that you started a PR, but its not gonna help on the problem by itself. Here is a patch file I created which has a lot of tweaks to bring the look of the iOS and Android versions closer to each other:

@react-native-community+blur+4.3.2.patch

Can you please apply this to your repository somehow?

@stemyke
Copy link

stemyke commented Oct 6, 2023

I hope when its done, then @Kureev can help us merge it.

@dopplerDistortion
Copy link
Author

@stemyke Hey! I tried but, patch file has some auto generated changes and files inside. If you can send the diff your changes instead of patch file it would be much more useful.

@stemyke
Copy link

stemyke commented Oct 6, 2023

Sure! Here are all the files from the package including the modified ones:

blur.zip

@dopplerDistortion
Copy link
Author

dopplerDistortion commented Oct 6, 2023

@stemyke Just pushed it to the PR. But I couldn't understand why BlurViewManagerImpl.java inside main folder and BlurViewManager.java file inside oldarch folder is deleted. Could you give us a explanation for that ? After that @Kureev can review it properly I'm sure.

@stemyke
Copy link

stemyke commented Oct 6, 2023

@dopplerDistortion Oh no! You are right, I did not understand why was the BlurViewManager separated from its implementation, now I get it, because it was based on the RN architecture and it is different. Can you please restore BlurViewManager to its original place, but only with the tweaked and removed properties? And please do that also in the newarch if you can. I feel like the BlurViewManagerImpl is still unnecessary because now I am doing the necessary calculations inside the BlurView.

Edit: I only use oldarch in my project and I did the changes directly in node_modules and thats why I did not notice it.

@dopplerDistortion
Copy link
Author

@stemyke it is restored to original place. But I don't have enough understanding about new arch. Maybe you can send their changes after checking it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bleeding BlurView in Android
2 participants