Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds creation of flags and nodes via double-click and Drag&Drop #427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LauraRozier
Copy link
Contributor

This might assist with solving the issues of #323

@LauraRozier
Copy link
Contributor Author

@reyandme I tried to make a PR to your repo, but it seems to be lagging behind a bit, hence there is no PR. :)

@reyandme
Copy link
Contributor

@thibmo, what do you mean by lagging ? You have some problems with internet connection?
Anyway, I can try to use cheerypick commit to move it into my repo

@LauraRozier
Copy link
Contributor Author

Nono, as in your "master" branch is behind in commits. :)

@reyandme
Copy link
Contributor

Ok, cherrypicked into my repository

@reyandme
Copy link
Contributor

reyandme commented Nov 15, 2017

I have found a bug with drag'n'drop feature - if try to place Flag near left or top border of background image - got an exception, cause of Word type and negative left/top value for flag image. Fixed in my repo with commit: reyandme@2916382

Also fixed selection for new node/flag

@LauraRozier
Copy link
Contributor Author

Thanks, will include it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants