Introduced dovecot authN module #946
Conversation
This work is heavily based on prior art by Giel van Schijndel, however the code was made Python 3 compatible, error checking has been improved, and tests were introduced: $ python setup.py test --extras --addopts "-k auth" [skipped] Name Stmts Miss Branch BrPart Cover ------------------------------------------------------------- radicale/auth/dovecot.py 76 2 26 2 96% [skipped] === 34 passed, 16 skipped, 198 deselected in 2.35 seconds ===
|
JFYI, Travis CI fails on other tests not the ones introduced by this PR. |
|
I use https://github.com/comzeradd/radicale-imap works great 👍 |
|
The application is different, this authN module is needed if you want to integrate with Dovecot's authentication backend. I am going to make another PR that uses Dovecot storage API to store calendars and vcards soon, too. |
|
Also, passing credentials over a Unix socket is faster and more secure than making an external IMAP call. At least, when Radicale is running on the same instance. |
|
The imap plugin was the only way for me, your PR looks like very nice! |
Unrud
force-pushed
the
master
branch
3 times, most recently
from
767d614
to
41bccb2
Compare
|
It's been more than 18 months since this PR was submitted. Is there anything I could do to expedite its approval and merging into the master branch? |
Wow! 4 years turn around, this is my first :). Will try to carve out time and see what I can do. |
This work is heavily based on prior art by Giel van Schijndel (#200),
however the code was made Python 3 compatible, error checking
has been improved, and tests were introduced: