Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create predefined calendar or(and) addressbook for new user #1473

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itglob
Copy link
Contributor

@itglob itglob commented Apr 22, 2024

No description provided.

@pbiering pbiering added this to the 3.2.0 milestone Apr 23, 2024
config Show resolved Hide resolved
@pbiering
Copy link
Collaborator

Good idea, but please check my comments.

@itglob
Copy link
Contributor Author

itglob commented Apr 27, 2024

disabled by default
json_str return {} (empty dict)
radicale/app/__init__.py - line 275 - empty loop

is my example in documentation and config unclear?

@pbiering
Copy link
Collaborator

I had no time to test so far, but scheduled

@pbiering
Copy link
Collaborator

pbiering commented May 3, 2024

Can you please extend the code that it validates the config option during start? It would be helpful to avoid any broken config sniplet detected only on the "new user" trigger.

@pbiering pbiering modified the milestones: 3.2.0, 3.1.x May 3, 2024
@itglob
Copy link
Contributor Author

itglob commented May 3, 2024

Which aspect should I check? The json syntax is checked during json.loads in config.py.

@pbiering
Copy link
Collaborator

pbiering commented May 3, 2024

Which aspect should I check? The json syntax is checked during json.loads in config.py.

Best that they are valid collection properties (calendar or address book).

Alternative: hardcode and only add an option for enabling of that feature, then the QA can be done by test script.

@itglob
Copy link
Contributor Author

itglob commented May 3, 2024

check_and_sanitize_props called before create_collection in app/__init__.py - l277
i didn't think we need do this in config.

@pbiering
Copy link
Collaborator

pbiering commented May 3, 2024

check_and_sanitize_props called before create_collection in app/__init__.py - l277 i didn't think we need do this in config.

but this will be triggered on first usage only, and then it breaks....I would expect that "preloaded" config is assured working and not waiting to fail on first usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants