Added FileHandler for logging #1165
Conversation
|
@Unrud Any reason why this shouldn't be merged? |
| @@ -218,6 +218,11 @@ def _convert_to_bool(value): | |||
| "value": "warning", | |||
| "help": "threshold for the logger", | |||
| "type": logging_level}), | |||
| ("logfile", { | |||
| "value": "/tmp/radicale.log", | |||
There was a problem hiding this comment.
I am not part of the Radicale team, so this is a quick review by a random developer.
The string "/tmp/radicale.log" is considered True in Python. As such this will by default enable logging to "/tmp/radicale.log". As "/tmp" is a world-writable directory, if any other users exist on the system they can cause Radicale to overwrite any file writable by Radicale. In other words, I'm pretty sure this is a security hole.
There was a problem hiding this comment.
Logging to /tmp in an example is ugly.
| @@ -110,6 +110,8 @@ | |||
| # Value: debug | info | warning | error | critical | |||
| #level = warning | |||
|
|
|||
| logfile = /var/log/radicale.log | |||
There was a problem hiding this comment.
this can trigger SELinux issues, better would be /var/log/radicale/radicale.log + a proper logwatch configuration for rotation, in case no autorotation is implemented
|
@ekaats : please rebase to latest Radicale 3 and also check all comments. |
Solves #1158
Added a FileHandler for logging. Two things I am not sure about: