Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt AutoCloseable from standard library for CloseableCoroutineDispa… #4123

Merged
merged 3 commits into from
May 27, 2024

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented May 8, 2024

…tcher

  • It's stable in 2.0
  • For JVM, use Java's AutoCloseable as on Kotlin 1.9.x there is no JVM counterpart

@qwwdfsad qwwdfsad requested a review from dkhalanskyjb May 8, 2024 15:01
@qwwdfsad
Copy link
Member Author

qwwdfsad commented May 8, 2024

I won't merge this PR though until we update on Kotlin 2.0, so JVM counterpart is handled in a less ad-hoc manner

@qwwdfsad qwwdfsad force-pushed the stdlib-closeable branch 2 times, most recently from ac5e87b to ddf0e67 Compare May 17, 2024 09:33
…tcher

* It's stable in 2.0
* For JVM, use Java's AutoCloseable as on Kotlin 1.9.x there is no JVM counterpart
@qwwdfsad qwwdfsad merged commit 259000f into develop May 27, 2024
1 check passed
@qwwdfsad qwwdfsad deleted the stdlib-closeable branch May 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants