Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/simple dex testcoins #2422

Merged
merged 3 commits into from Apr 6, 2024
Merged

Fix/simple dex testcoins #2422

merged 3 commits into from Apr 6, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Apr 2, 2024

Closes #2369

To Test (pro view):

  • Select DOC in the left combo selector on dex pro page.
  • Select MARTY in right combo selector on dex pro page.
  • Click on an order in the orderbook
  • See only testcoins listed in bestorders box

image

To Test (simple view):

  • Select DOC to sell in simple dex view.
  • Enter a value to sell
  • Expand the buy coin selection list
  • See only testcoins listed in buy coin selection list

image

Inverted test (pro):

  • Testcoins should also be excluded from bestorder response for coins with value. I've set up a maker order for MARTY -> PANDA to help test this.
  • First confirm the PND/MARTY order exists. If it doesn't, pinf me and I'll create another one.

image

  • Next, select PND in left combo in pro view, and click on an order in the orderbook to show the bestorders.
  • MARTY should be excluded from the list.

image

Inverted test (simple):

  • Select PND to sell in simple dex view (if you have no PND balance, do a small trade to get some, its cheap).
  • enter an amount to sell to activate the buy section.
  • Confirm MARTY does not appear in the buy coin selection list.
    image

NOTE: Pro view has since been updated to the new tabbed orderbook/bestorders layout, so the screenshots above are indicative but not how app currently looks. Updated view below for reference.

updated-view.mp4

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing successful. Items tested:

  • (Pro) Swap 2 Test Coins: Confirmed only test coins are displayed in Best Orders
  • (Simple) Select Test Coin to Trade: Confirmed only test coins are displayed for available trades
  • (Pro) Swap Coin with Value: Confirmed test coins do not show in Best Orders
  • (Simple) Select Coin with Value: Confirmed test coins are not displayed in available trades
  • General wallet functionality is unaffected
  • UI functionality is unaffected

@smk762 smk762 merged commit 2bb35a2 into dev Apr 6, 2024
6 checks passed
@smk762 smk762 deleted the fix/simple-dex-testcoins branch April 6, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: DOC/MARTY pair does not have orders on Simple DEX view
2 participants