Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/order info #2420

Merged
merged 6 commits into from Apr 6, 2024
Merged

Add/order info #2420

merged 6 commits into from Apr 6, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Apr 1, 2024 •
edited

Closes #2412
cc: @TheComputerGenie

To Test:

  • Create an order which will not be matched (e.g. Sell 1 DOC for 10 MARTY).
  • Wait for the order to revert to maker after 60 seconds.
  • Click on the order to view its details
  • See text for Max volume and Min volume in order details modal

image

@smk762 smk762 mentioned this pull request Apr 4, 2024
Merged
AndrewDelaney
AndrewDelaney approved these changes Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing successful. The following items were tested:

  • Order that cannot be match is created and added to orders list
  • Order reverts to maker after 60 seconds
  • Detailed view of order displays min and max volumes

@smk762 smk762 merged commit fa1821f into dev Apr 6, 2024
6 checks passed
@smk762 smk762 deleted the add/order-info branch April 6, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewDelaney AndrewDelaney AndrewDelaney approved these changes

@cipig cipig Awaiting requested review from cipig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Add min/max trade info for orders modal
2 participants
@smk762 @AndrewDelaney