Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orderbook cancel button #2419

Merged
merged 3 commits into from Apr 4, 2024
Merged

Fix orderbook cancel button #2419

merged 3 commits into from Apr 4, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 31, 2024

Partial fix for #2412
cc: @TheComputerGenie

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully. The following was tested:

  • DOC / MARTY swap to create order
  • Once order appeared in Order Book:
    • Confirmed custom order was marked
    • Confirmed close (x) button appears on the custom order when moused over the order
    • Close (x) button highlights when moused over of the button
    • Clicking on the close (x) button cancels the swap and removes the order from the Order Book

@smk762 smk762 merged commit 5cd7124 into dev Apr 4, 2024
6 checks passed
@smk762 smk762 deleted the fix/orderbook-cancel branch April 4, 2024 15:44
@TheComputerGenie
Copy link

Now that you guys have made the app this tragic:
image
maybe untag me? I really don't want people thinking I had any thing to do with this "updated" design!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants