Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm paprika api services #2414

Merged
merged 2 commits into from Apr 4, 2024
Merged

rm paprika api services #2414

merged 2 commits into from Apr 4, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 28, 2024

Replaces #2413

To Test:

  • Confirm tickers are returning correct price / balance data in all areas of the app
  • Confirm fiat conversions are applied as expected

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue when switching currencies on the wallet page, where the balance of a coin is not updated correctly. The currency symbol changes, but the number does not.
This issue was not introduced, it existed before, but am not sure if this was meant to be addressed in this PR?

See video for details:

CurrencyUpdateIssue.mp4

@smk762 smk762 merged commit 3f19105 into dev Apr 4, 2024
6 checks passed
@smk762 smk762 deleted the remove/paprika branch April 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants