Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addresbook protocols #2286

Draft
wants to merge 3 commits into
base: v0.5.8
Choose a base branch
from
Draft

Add addresbook protocols #2286

wants to merge 3 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jun 8, 2023

Closes #1337
image

To Test:

  • login
  • Go to wallet page and copy address for an EMV token from the new protocols (e.g. PLG20, AVX20, FTM20)
  • Go to addressbook go to add a new address
  • Toggle on "use standard network address" and select the network type
  • add address (testing validation)
  • save changes
  • confirm no missing icons.

Known issues
Segwit compatible coins are appearing twice in the individual coins menu #2285

@kivqa
Copy link

kivqa commented Jun 13, 2023

@smk762 when I want to add LTC address to Address book I see two Litecoin UTXO one of this Segwit, right?
image

@smk762
Copy link
Collaborator Author

smk762 commented Jun 13, 2023

Yes - that issue was identified by not yet resolved #2285

@smk762
Copy link
Collaborator Author

smk762 commented Jun 13, 2023

Found another bug in this PR - when editing entries for newer protocols, it reverts to "new address" form.

adressbook.mp4

This PR will be held back for 0.5.9 so this and other identified issues can be resolved.

@kivqa
Copy link

kivqa commented Jun 13, 2023

Another one bug
Addresses disappeared for 1st entry in address book.
Steps:

  1. Add few contacts to to address books and add address for these contacts
  2. Go to Wallet, open any asset and click send.
  3. Close send form
  4. Go to Address book check 1st contact
    Result: 1st contact does not have addresses. After app reload addresses displayed again
    image
    image

@endrilickollari
Copy link

@kivqa @smk762 tested and happened the same to me. btw as is in the test description icons are okay.

@smk762 smk762 removed the next iteration to not forget to include it label Sep 10, 2023
@smk762 smk762 marked this pull request as draft December 20, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressbook impact_ux P1 Major issue needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants