Allow serving under a non-root base path #19911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for scenarios where zigbee2mqtt is behind a reverse proxy. For example `example.com/zigbee2mqtt` instead of a root path like `zigbee2mqtt.example.com`. Related issues: - nurikk/zigbee2mqtt-frontend#275 - nurikk/zigbee2mqtt-frontend#971 - nurikk/zigbee2mqtt-frontend#1690
JamieMagee
force-pushed
the
frontend-path
branch
from
ac993bd
to
bec78e0
Compare
|
Could you also make a pr for the docs? |
sjorge
reviewed
Dec 14, 2023
| // @ts-ignore | ||
| this.fileServer(request, response, finalhandler(request, response)); | ||
| } else { | ||
| response.writeHead(404).end(); |
There was a problem hiding this comment.
Perhaps use a 302 and point it to the path, that way if no reverse proxy is used (e.g. curl on localhost) it would end up on the correct spot.
There was a problem hiding this comment.
Perhaps use a 302 and point it to the path, that way if no reverse proxy is used (e.g. curl on localhost) it would end up on the correct spot.
Can we accept this? This is a QOL comment on a real issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for scenarios where zigbee2mqtt is behind a reverse proxy. For example
example.com/zigbee2mqttinstead of a root path likezigbee2mqtt.example.com.I also tried to make the WS server available under the same path, but wasn't able to test these changes. I'd appreciate and input or help on testing that.
Related issues: