Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger.hasHandlers() to setup fallback logging #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wesleyjellis
Copy link

Instead of checking if the django-q logger has any handlers directly, use the hasHandlers method, which will check if any parent loggers have handlers as well.

This fixes a bug where django-q configures it's own logging even though the root logger has a handler set

import logging

root_logger = logging.getLogger()
django_q_logger = logging.getLogger("django-q")

print("list of djando_q handlers", django_q_logger.handlers)
# []
print("does django_q have handlers?", django_q_logger.hasHandlers())
# False

root_logger.addHandler(logging.StreamHandler())

print("list of djando_q handlers", django_q_logger.handlers)
# []
print("does django_q have handlers?", django_q_logger.hasHandlers())
# True

Instead of checking if the django-q logger has any handlers directly,
use the hasHandlers [1] method, which will check if any parent loggers
have handlers as well.

This fixes a bug where django-q configures it's own logging even though
the root logger has a handler set

 1. https://docs.python.org/3/library/logging.html#logging.Logger.hasHandlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant