Extender 'ignoreInValidationGroup' to guard observables from being added to validation groups #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed line endings of "Localization/el-GR.js".
This extender can be used to flag a Knockout Observable to be ignored in validation groups. When the extender is set the observable will not be added to validation groups. Rules added to a flagged obserable still apply but the errors are not shown in any group.
|
This idea might be suited for #478 |
|
computeds are no longer resolved unless they have rules defined on them #501. |
This was referenced Feb 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We show all errors in a list using ko.group's
errorsmethod. We have some observableArrays in the view model for which we created computeds filtering them. That caused validation messages to appear twice. The reason was that group's traverse (when using deep) follows eachko.observableandko.computedinherits fromobservable.Therefore I have added an knockout extender 'ignoreInValidationGroup'.
This extender can be used to flag a Knockout Observable to be ignored in validation groups.
When the extender is set the observable will not be added to validation groups.
Rules added to a flagged obserable still apply but the errors are not shown in any group.