replaced lexerStream with text/scanner.Scanner #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 12, 2017 16:32
featurechanges: Don't escape single quotes in double qiates: Use "abc's" instead of "abc\'s" Added Support for new quote `abc` with unescapable content Added Support for Unicode number codes '\u263a'
|
I'm still going over the change, but all the tests are passing and i think the change to quoting is fine - it always felt like a bug to allow something like |
|
This change is good, but I'm going to wait to merge until a new major version is ready - this is a big enough API break that it'll probably affect downstreams. |
|
ok, cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've replaced the lexerStream type with the golang text/scanner.Scanner type. My commit causes syntax changes with string escaping. Now there is a real difference between single and double quotes.
'abc" is no longer a vailid string. In exchange "abc's", 'a"b"c' and '\u263a' are valid now.