Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added isName function and added '$' to test #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added isName function and added '$' to test #124

wants to merge 1 commit into from
+7 −3

Conversation

sampaioletti
Copy link

Fixes #118

@rohitkeshwani07
Copy link

I have a similar use case but don't u think it should be configurable?

@sampaioletti
Copy link
Author

Sure I think thats an idea, are you thinking ability to pass in whatever runes you would like or just ability to enable/disable '$'

@rohitkeshwani07
Copy link

rohitkeshwani07 commented Apr 30, 2019 •
edited

Whatever is between [ and ] is treated as variable right now. What if these 2 can be configured??

Prefix and Suffix to find the variable?

For our usecase it will be $ and space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow '$' prefix for variable and function names
3 participants
@sampaioletti @rohitkeshwani07 @antonmedv