Framebuffer light intensity mapping extension - draft spec #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
requested changes
May 15, 2024
| vec3 scaledRGB = RGB / max(R, max(G,B)); | ||
|
|
||
|
|
||
| ## Defining an asset to use KHR_framebuffer_value_mapping |
There was a problem hiding this comment.
Can you add example renders comparing your tone mapping function to others, e.g. Linear, ACES, PBR Neutral and demonstrating the pros and cons compared to each? One model that might make for an interesting comparison is my 3D Macbeth color chart model.
There was a problem hiding this comment.
I can certainly include a couple of images of how glTFs will look using this extension with different maxLight values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way of declaring an extension that will provide a light scale factor to be used in shading to produce valid display output.
This is done by way of declaring that the output is some sort of framebuffer.
This is NOT a physical camera extension that defines aperture, shutter or ISO (exposure)