layers: Check vkGetDescriptorSetLayoutSupport #7609
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 141862. |
| @@ -4141,286 +4141,309 @@ TEST_F(NegativeDescriptors, BindingDescriptorSetFromHostOnlyPool) { | |||
| m_commandBuffer->end(); | |||
| } | |||
|
|
|||
| TEST_F(NegativeDescriptors, CopyMutableDescriptors) { | |||
There was a problem hiding this comment.
this test was already basically 3 tests, so just broke it up to improve coverage on MESA (2 of the 3 work, and didn't want to skip the other 2)
|
CI Vulkan-ValidationLayers build # 15969 running. |
|
CI Vulkan-ValidationLayers build # 15969 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-checkdescriptor
branch
from
8a7931d
to
e5af159
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 142561. |
|
CI Vulkan-ValidationLayers build # 15981 running. |
|
CI Vulkan-ValidationLayers build # 15981 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-checkdescriptor
branch
from
e5af159
to
03ec6d1
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 144140. |
|
CI Vulkan-ValidationLayers build # 16005 running. |
|
CI Vulkan-ValidationLayers build # 16005 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-checkdescriptor
branch
from
03ec6d1
to
9807d3a
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 145234. |
|
CI Vulkan-ValidationLayers build # 16026 running. |
|
CI Vulkan-ValidationLayers build # 16026 failed. |
| std::stringstream error_str; | ||
| error_str << "was passed into vkGetDescriptorSetLayoutSupport and returned not supported"; | ||
| if (using_mutable_type) { | ||
| error_str << " (verify mutable type are supported, not every driver supports mutable types such as " |
There was a problem hiding this comment.
| error_str << " (verify mutable type are supported, not every driver supports mutable types such as " | |
| error_str << " (verify mutable types are supported, not every driver supports mutable types such as " |
spencer-lunarg
force-pushed
the
spencer-lunarg-checkdescriptor
branch
from
9807d3a
to
e5439bc
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 149388. |
|
CI Vulkan-ValidationLayers build # 16103 running. |
|
CI Vulkan-ValidationLayers build # 16103 failed. |
From https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/6269
Call
vkGetDescriptorSetLayoutSupportfor appsthis catches Mutable Descriptor tests failing on MESA because they don't support
VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER(but NVIDIA does)