Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve matrix layout validation #5662

Merged
merged 2 commits into from May 14, 2024

Conversation

alan-baker
Copy link
Contributor

@alan-baker alan-baker commented May 7, 2024

  • Check for matrix decorations on arrays of matrices
    • MatrixStide, RowMajor and ColMajor can be applied to matrix or arrays of matrix members
    • Check that matrix stride satisfies alignment in arrays

cc @jrprice

See https://crbug.com/339270841

* Check for matrix decorations on arrays of matrices
  * MatrixStide, RowMajor and ColMajor can be applied to matrix or
    arrays of matrix members
  * Check that matrix stride satisfies alignment in arrays
@alan-baker alan-baker requested a review from dneto0 May 7, 2024 19:22
@alan-baker alan-baker added this to In progress in Validator via automation May 7, 2024
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@alan-baker alan-baker merged commit ccf3e3c into KhronosGroup:main May 14, 2024
24 checks passed
Validator automation moved this from In progress to Done May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Validator
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants