spirv-val: Add Vulkan Image Format check #5458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2023
alan-baker
requested changes
Oct 30, 2023
alan-baker
requested changes
Nov 1, 2023
|
There are several glslang unit test failures. The sparse failures look like a spec problem. Sparse samples return a struct with residency and value. The zero/sign extend should apply to the second element. The image write case is a similar problem, spec says result type, but there is no result type. I'm unsure about the HLSL test. It looks incorrect to me, but I'm not sure what the strategy for specifying formats is when compiling HLSL. |
|
See Khronos internal issue 766. |
|
with https://gitlab.khronos.org/spirv/SPIR-V/-/merge_requests/302 merged, will apply and rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at #4748
checks for
VUID-StandaloneSpirv-Image-04965