working on some missing enum groups #431

3b · 2020-10-04T02:47:48Z

Not done yet, but could use more eyes (and runs through other binding generators) to see if there are any obvious mistakes so far.

Adding in anything missing that has been found by cl-opengl users, along with whatever I can find missing by scraping the cl-opengl wrappers (and also just went through the 4.6 compat spec and added most of the glGet* and IsEnabled since that was a big chunk of what was missing for wrappers).

Perksey · 2020-10-04T14:08:05Z

LGTM so far.

mostly for various gets, but VertexAttribEnumNV was used on a bunch of other functions, so added groups for those too VertexAttribEnum,VertexAttribPropertyARB -> GetVertexAttribPName VertexAttribPointerPropertyARB -> GetVertexAttribPointerPName VertexArrayPNameAPPLE -> VertexArrayParamAPPLE and add new VertexArrayPNameAPPLE for actual pname arg VertexArrayPName -> GetVertexArrayIndexedPName, GetVertexArrayIndexed64PName, GetVertexArrayPName, GetVertexArrayIntegeriPNameEXT, GetVertexArrayIntegerPNameEXT, GetVertexArrayPointeriPNameEXT, GetVertexArrayPointervPNameEXT VertexAttribEnumNV -> ProgramTargetNV, LoadProgramTargetNV, ProgramAttribPNameNV, ProgramParameterPNameNV, VertexProgramAttribPointerPNameNV, ProgramPNameNV, ProgramStringPNameNV, VertexProgramGetTrackMatrixPNameNV, VertexProgramTrackMatrixMatrixNV

Spec lists same set of args for all functions (query table lists preferred Get for each, but doesn't seem to restrict use of others, even if they might not be useful)

3b · 2020-10-14T21:25:37Z

OK, possibly done with edits for now if people want to look at it more closely. Leaving PR as draft for now until I finish my local testing.

Perksey

There are a few things I'm uncertain about in here.

The TL;DR of it is that gl.xml is used by a lot of libraries, amassing a large amount of downstream consumers. All it'd take is an update in which their bindings are regenerated and they've potentially broken lots of projects.

For this reason, generally defer group removals and renames.

Other than that, this PR is great and thank you for being among the few improving the groupings! <3

Perksey · 2020-10-15T20:54:33Z

xml/gl.xml

@@ -450,7 +450,7 @@ typedef unsigned int GLhandleARB;
            <enum name="GL_CLAMP_READ_COLOR"/>
        </group>

-        <group name="VertexArrayPNameAPPLE" comment="Deprecated, use the group attributes instead.">
+        <group name="VertexArrayParamAPPLE" comment="Deprecated, use the group attributes instead.">


Changes shouldn't be made to the old groups (you've renamed it here) as they are pending removal.

Perksey · 2020-10-15T20:54:48Z

xml/gl.xml

@@ -3873,17 +3873,14 @@ typedef unsigned int GLhandleARB;
            <enum name="GL_UNIFORM_ATOMIC_COUNTER_BUFFER_INDEX"/>
        </group>

-        <group name="SamplerParameterI" comment="Deprecated, use the group attributes instead.">
+        <group name="SamplerParameterPName" comment="Deprecated, use the group attributes instead.">


Perksey · 2020-10-15T20:55:40Z

xml/gl.xml

@@ -5638,20 +5635,20 @@ typedef unsigned int GLhandleARB;
        <enum value="0x1001" name="GL_TEXTURE_HEIGHT" group="TextureParameterName,GetTextureParameter"/>
        <enum value="0x1003" name="GL_TEXTURE_INTERNAL_FORMAT" group="TextureParameterName,GetTextureParameter"/>
        <enum value="0x1003" name="GL_TEXTURE_COMPONENTS" group="TextureParameterName,GetTextureParameter"/>
-        <enum value="0x1004" name="GL_TEXTURE_BORDER_COLOR" group="SamplerParameterF,GetTextureParameter,TextureParameterName"/>
-        <enum value="0x1004" name="GL_TEXTURE_BORDER_COLOR_EXT"/>
+        <enum value="0x1004" name="GL_TEXTURE_BORDER_COLOR" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>


I get that the SamplerParameterF name is inconsistent with literally every other group name here, however renaming this would technically break downstream consumers so I think this should be reverted.

I tend to defer breaking group changes unless the change poses a significant improvement for downstream consumers, such as if two groups were valid for the same parameter and are being merged, or a more generalized group is being added allowing use on more functions.

Seeing as you haven't annotated more functions with this group attribute and I don't think there are any other improvements other than making this name conform with the nomenclature used everywhere else, I don't think this is enough to justify the breaking changes in downstream libraries.

The main problem is that the grouping in the spec is divided into SamplerParameterI and SamplerParameterF. If we don't want to remove old groups, we would need to add enums from each to the other, then always remember to add them both. Not sure which is a better solution.

It's an ugly situation we've gotta live with unfortunately due to how high-profile these groups are.

Somehow I missed 2 paragraphs of your first response, so my answer wasn't very clear. In this case, there are 2 groups (SamplerParameterI and SamplerParameterF) that are both (more or less) valid for every use of either group, so I merged them into one SamplerParameterPName. Don't have much objection to keeping both as duplicates though, if you think that would be better, aside from the part where I have to go back to the spec to check that "more or less" to see if some uses are "valid but undefined" or whatever that might make them worth removing from one group.

both (more or less) valid for every use of either group

In that case this should be fine, though I'd like to keep the old group names in addition to the new one.

Perksey · 2020-10-15T20:56:12Z

xml/gl.xml

@@ -33088,7 +33085,7 @@ typedef unsigned int GLhandleARB;
            <proto>void <name>glVertexAttribPointerNV</name></proto>
            <param><ptype>GLuint</ptype> <name>index</name></param>
            <param><ptype>GLint</ptype> <name>fsize</name></param>
-            <param group="VertexAttribEnumNV"><ptype>GLenum</ptype> <name>type</name></param>
+            <param group=""><ptype>GLenum</ptype> <name>type</name></param>


You've left this group attribute empty. Consider readding VertexAttribEnumNV?

thanks, will check and see what that should be (VertexAttribEnumNV was almost entirely incorrect if i remember right, which makes it a better candidate for complete replacement. Only had 1 enum, which isn't accepted by most of the parameters labelled with that group)

Perksey · 2020-10-15T21:03:17Z

xml/gl.xml

+        <enum value="0x2800" name="GL_TEXTURE_MAG_FILTER" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>
+        <enum value="0x2801" name="GL_TEXTURE_MIN_FILTER" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>
+        <enum value="0x2802" name="GL_TEXTURE_WRAP_S" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>
+        <enum value="0x2803" name="GL_TEXTURE_WRAP_T" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>
            <unused start="0x2804" end="0x28FF" comment="Unused for TextureParameterName"/>


Same as above (won't comment on any other occurances of this herein)

Perksey · 2020-10-15T21:07:26Z

xml/gl.xml

-        <enum value="0x8644" name="GL_PROGRAM_PARAMETER_NV" group="VertexAttribEnumNV"/>
-        <enum value="0x8645" name="GL_ATTRIB_ARRAY_POINTER_NV"/>
-        <enum value="0x8645" name="GL_VERTEX_ATTRIB_ARRAY_POINTER" group="VertexAttribPointerPropertyARB"/>
-        <enum value="0x8645" name="GL_VERTEX_ATTRIB_ARRAY_POINTER_ARB" group="VertexAttribPointerPropertyARB"/>


What's happened to these three groups?

VertexAttribEnumNV as mentioned above was pretty much useless and got replaced with a bunch of correct enums.

VertexAttribPointerPropertyARB looks like it might have just been renamed, can change it back if that's a problem.

3b · 2020-10-15T21:39:12Z

I'll look at trying to minimize changes that would affect existing groups, and keep existing names where possible, Some will still end up split and some parameter groups changed, though, unless we want to just keep piling "wrong" enums into random groups because they were once applied to the wrong function.

3b · 2020-10-17T21:28:29Z

@Perksey I merged VertexAttribEnum and VertexAttribPropertyARB into a single group GetVertexAttribPName, does that look reasonable, or should those be kept as duplicates?

was: (some names reformatted oddly since i queried them from my bindings)

VertexAttribEnum:
   :CURRENT-VERTEX-ATTRIB
   :VERTEX-ATTRIB-ARRAY-BUFFER-BINDING
   :VERTEX-ATTRIB-ARRAY-DIVISOR
   :VERTEX-ATTRIB-ARRAY-ENABLED
   :VERTEX-ATTRIB-ARRAY-INTEGER
   :VERTEX-ATTRIB-ARRAY-NORMALIZED
   :VERTEX-ATTRIB-ARRAY-SIZE
   :VERTEX-ATTRIB-ARRAY-STRIDE
   :VERTEX-ATTRIB-ARRAY-TYPE

   glGetVertexAttribIiv: pname = VertexAttribEnum
   glGetVertexAttribIuiv: pname = VertexAttribEnum
   glGetVertexAttribLdv: pname = VertexAttribEnum
   glGetVertexAttribLui64vARB: pname = VertexAttribEnum
   glGetVertexAttribIivEXT: pname = VertexAttribEnum
   glGetVertexAttribIuivEXT: pname = VertexAttribEnum
   glGetVertexAttribLdvEXT: pname = VertexAttribEnum
   glGetVertexAttribLi64vNV: pname = VertexAttribEnum
   glGetVertexAttribLui64vNV: pname = VertexAttribEnum

VertexAttribPropertyARB:
   :CURRENT-VERTEX-ATTRIB
   :VERTEX-ATTRIB-ARRAY-BUFFER-BINDING
   :VERTEX-ATTRIB-ARRAY-DIVISOR
   :VERTEX-ATTRIB-ARRAY-ENABLED
   :VERTEX-ATTRIB-ARRAY-INTEGER
   :VERTEX-ATTRIB-ARRAY-INTEGER-EXT
   :VERTEX-ATTRIB-ARRAY-LONG
   :VERTEX-ATTRIB-ARRAY-NORMALIZED
   :VERTEX-ATTRIB-ARRAY-SIZE
   :VERTEX-ATTRIB-ARRAY-STRIDE
   :VERTEX-ATTRIB-ARRAY-TYPE
   :VERTEX-ATTRIB-BINDING
   :VERTEX-ATTRIB-RELATIVE-OFFSET

   glGetVertexAttribdv: pname = VertexAttribPropertyARB
   glGetVertexAttribfv: pname = VertexAttribPropertyARB
   glGetVertexAttribiv: pname = VertexAttribPropertyARB

   glGetVertexAttribdvARB: pname = VertexAttribPropertyARB
   glGetVertexAttribfvARB: pname = VertexAttribPropertyARB
   glGetVertexAttribivARB: pname = VertexAttribPropertyARB

new:

  :CURRENT-VERTEX-ATTRIB
  :CURRENT-VERTEX-ATTRIB-ARB
  :VERTEX-ATTRIB-ARRAY-BUFFER-BINDING
  :VERTEX-ATTRIB-ARRAY-BUFFER-BINDING-ARB
  :VERTEX-ATTRIB-ARRAY-DIVISOR
  :VERTEX-ATTRIB-ARRAY-DIVISOR-ANGLE
  :VERTEX-ATTRIB-ARRAY-DIVISOR-ARB
  :VERTEX-ATTRIB-ARRAY-DIVISOR-EXT
  :VERTEX-ATTRIB-ARRAY-DIVISOR-NV
  :VERTEX-ATTRIB-ARRAY-ENABLED
  :VERTEX-ATTRIB-ARRAY-ENABLED-ARB
  :VERTEX-ATTRIB-ARRAY-INTEGER
  :VERTEX-ATTRIB-ARRAY-INTEGER-EXT
  :VERTEX-ATTRIB-ARRAY-LONG
  :VERTEX-ATTRIB-ARRAY-NORMALIZED
  :VERTEX-ATTRIB-ARRAY-NORMALIZED-ARB
  :VERTEX-ATTRIB-ARRAY-SIZE
  :VERTEX-ATTRIB-ARRAY-SIZE-ARB
  :VERTEX-ATTRIB-ARRAY-STRIDE
  :VERTEX-ATTRIB-ARRAY-STRIDE-ARB
  :VERTEX-ATTRIB-ARRAY-TYPE
  :VERTEX-ATTRIB-ARRAY-TYPE-ARB
  :VERTEX-ATTRIB-BINDING
  :VERTEX-ATTRIB-MAP1-COEFF-APPLE :VERTEX-ATTRIB-MAP1-DOMAIN-APPLE
  :VERTEX-ATTRIB-MAP1-ORDER-APPLE :VERTEX-ATTRIB-MAP1-SIZE-APPLE
  :VERTEX-ATTRIB-MAP2-COEFF-APPLE :VERTEX-ATTRIB-MAP2-DOMAIN-APPLE
  :VERTEX-ATTRIB-MAP2-ORDER-APPLE :VERTEX-ATTRIB-MAP2-SIZE-APPLE
  :VERTEX-ATTRIB-RELATIVE-OFFSET
  :VERTEX-ELEMENT-SWIZZLE-AMD

  glGetVertexAttribIiv: pname = GetVertexAttribPName
  glGetVertexAttribIivEXT: pname = GetVertexAttribPName
  glGetVertexAttribIuiv: pname = GetVertexAttribPName
  glGetVertexAttribIuivEXT: pname = GetVertexAttribPName
  glGetVertexAttribLdv: pname = GetVertexAttribPName
  glGetVertexAttribLdvEXT: pname = GetVertexAttribPName
  glGetVertexAttribLi64vNV: pname = GetVertexAttribPName
  glGetVertexAttribLui64vARB: pname = GetVertexAttribPName
  glGetVertexAttribLui64vNV: pname = GetVertexAttribPName
  glGetVertexAttribdv: pname = GetVertexAttribPName
  glGetVertexAttribdvARB: pname = GetVertexAttribPName
  glGetVertexAttribfv: pname = GetVertexAttribPName
  glGetVertexAttribfvARB: pname = GetVertexAttribPName
  glGetVertexAttribiv: pname = GetVertexAttribPName
  glGetVertexAttribivARB: pname = GetVertexAttribPName

3b · 2020-10-17T21:41:07Z

Looks like the only correct use of VertexAttribEnumNV was for the pname of GetProgramParameterfvNV and GetProgramParameterdvNV, which I switched to use ProgramParameterPNameNV instead. None of the other places using it accepted the one enum in that group (PROGRAM_PARAMETE_NV), so doesn't seem worth preserving that group name.

3b · 2020-10-17T22:10:09Z

Removed changes to deprecated group tags, and renamed some groups to old names where they still matched reasonably well.

VertexArrayPNameAPPLE was pretty much useless before (it contained enums for param but was used on pname), so it got renamed to VertexArrayParamAPPLE and replaced with a group containing correct enums for pname.

VertexAttribEnumNV was similarly mostly wrong, but ProgramParameterPNameNV could be renamed back to that if keeping the old name for the one place it worked (GetProgramParameter[df]vNV) is worth having a confusing group name.

Let me know if you think it is worth duplicating SamplerParameterPName to SamplerParameterI + SamplerParameterF and/or GetVertexAttribPName to VertexAttribEnum+VertexAttribPropertyARB`

Perksey · 2020-10-18T15:47:25Z

xml/gl.xml

@@ -5638,20 +5635,20 @@ typedef unsigned int GLhandleARB;
        <enum value="0x1001" name="GL_TEXTURE_HEIGHT" group="TextureParameterName,GetTextureParameter"/>
        <enum value="0x1003" name="GL_TEXTURE_INTERNAL_FORMAT" group="TextureParameterName,GetTextureParameter"/>
        <enum value="0x1003" name="GL_TEXTURE_COMPONENTS" group="TextureParameterName,GetTextureParameter"/>
-        <enum value="0x1004" name="GL_TEXTURE_BORDER_COLOR" group="SamplerParameterF,GetTextureParameter,TextureParameterName"/>
-        <enum value="0x1004" name="GL_TEXTURE_BORDER_COLOR_EXT"/>
+        <enum value="0x1004" name="GL_TEXTURE_BORDER_COLOR" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>


both (more or less) valid for every use of either group

In that case this should be fine, though I'd like to keep the old group names in addition to the new one.

Perksey · 2020-10-18T15:48:39Z

xml/gl.xml

+        <enum value="0x2800" name="GL_TEXTURE_MAG_FILTER" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>
+        <enum value="0x2801" name="GL_TEXTURE_MIN_FILTER" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>
+        <enum value="0x2802" name="GL_TEXTURE_WRAP_S" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>
+        <enum value="0x2803" name="GL_TEXTURE_WRAP_T" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>


As discussed above,

Suggested change

<enum value="0x2800" name="GL_TEXTURE_MAG_FILTER" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>

<enum value="0x2801" name="GL_TEXTURE_MIN_FILTER" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>

<enum value="0x2802" name="GL_TEXTURE_WRAP_S" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>

<enum value="0x2803" name="GL_TEXTURE_WRAP_T" group="SamplerParameterPName,GetTextureParameter,TextureParameterName"/>

<enum value="0x2800" name="GL_TEXTURE_MAG_FILTER" group="SamplerParameterPName,SamplerParameterI,GetTextureParameter,TextureParameterName"/>

<enum value="0x2801" name="GL_TEXTURE_MIN_FILTER" group="SamplerParameterPName,SamplerParameterI,GetTextureParameter,TextureParameterName"/>

<enum value="0x2802" name="GL_TEXTURE_WRAP_S" group="SamplerParameterPName,SamplerParameterI,GetTextureParameter,TextureParameterName"/>

<enum value="0x2803" name="GL_TEXTURE_WRAP_T" group="SamplerParameterPName,SamplerParameterI,GetTextureParameter,TextureParameterName"/>

Won't comment on all instances of this.

Perksey · 2020-10-18T15:55:46Z

xml/gl.xml

+        <enum value="0x82D4" name="GL_VERTEX_ATTRIB_BINDING" group="GetVertexAttribPName"/>
+        <enum value="0x82D5" name="GL_VERTEX_ATTRIB_RELATIVE_OFFSET" group="GetVertexAttribPName,VertexArrayPName"/>


You should keep the old groups so that this change isn't too breaking.

Perksey · 2020-10-18T15:57:13Z

xml/gl.xml

-        <enum value="0x85BE" name="GL_STORAGE_CACHED_APPLE" group="VertexArrayPNameAPPLE"/>
-        <enum value="0x85BF" name="GL_STORAGE_SHARED_APPLE" group="VertexArrayPNameAPPLE"/>
+        <enum value="0x85BE" name="GL_STORAGE_CACHED_APPLE" group="VertexArrayParamAPPLE"/>
+        <enum value="0x85BF" name="GL_STORAGE_SHARED_APPLE" group="VertexArrayParamAPPLE"/>


Should probably change the name of this group back, for the reason that it's only to keep consistency and has no other meaningful change and will break downstream consumers.

Perksey · 2020-10-18T16:12:31Z

That change sounds fine, though if we are making breaking changes it's generally best to leave the old groups around so that all that's required is a simple implicit or explicit cast for users of the groups.

Perksey · 2020-10-18T16:13:12Z

@pdaniell-nv contains NVIDIA vendor extension grouping changes, comments would be appreciated,

3b · 2020-10-18T23:20:12Z

OK, will add the old group names back in addition to the merged ones, and rename the apple one. any suggestions for the name of the enum that actually gets passed to the pname argument?

What do you think about adding in a section for group aliases, so we can eventually drop the extra unused groups and just replace them with something like <group name="SamplerparameterI" alias="SamplerParameterPName">? I already have one of those as a manual type alias in my bindings from e04fd38, so seems like something that could be useful in general.

pdaniell-nv · 2020-10-19T22:05:43Z

@pdaniell-nv contains NVIDIA vendor extension grouping changes, comments would be appreciated,

I skimmed through and didn't see anything objectionable. We don't use the enum groups so if they work for consumers of those properties I'm happy.

Perksey · 2020-10-20T18:40:50Z

Awesome, yeah just figured I'd ping you in here to make sure that none of the values being marked as applicable to the extension functions are bogus :)

frederikja163 · 2021-05-19T20:50:42Z

We would love to see this PR getting merged at opentk. Anything you need to be done that we can assist with?

3b · 2021-05-23T05:33:58Z

@frederikja163 : reports that at least some of it is actively useful, and that the rest doesn't break things for existing code is helpful.

I'll push this back up towards the top of my todo list, but still a few things ahead of it so won't be able to get back to it immediately. If you have time before then, feel free to take care of some or all of the requested changes (I think it was mostly restoring old group names?).

3b added 8 commits October 3, 2020 13:28

add enums to PixelType group

4540620

add enums to LightParameter group

009eab1

add enums to FramebufferTarget and RenderbufferTarget groups

d9fd842

add groups to a bunch of enums for IsEnabled and Get*

7f1e507

add FramebufferAttachment group to COLOR_ATTACHMENT*_EXT

cfd2687

add InternalFormat group to DEPTH_COMPONENT24 and 32

e5c39e7

add groups to some depth/stencil attachment enums

4f39063

add group to MAX_TEXTURE_MAX_ANISOTROPY_EXT

42574a3

3b mentioned this pull request Oct 4, 2020

XML Format Consultation: Merging <groups> and <enums> #335

Closed

3b added 4 commits October 12, 2020 21:28

update FramebufferAttachment enum group

96b6c25

fix group for pname param of glGetFramebufferParameteriv

69027f5

Merge SamplerParameterI and SamplerParameterF groups, add missing enums

f6ba13a

Spec lists same set of args for all functions (query table lists preferred Get for each, but doesn't seem to restrict use of others, even if they might not be useful)

Perksey suggested changes Oct 15, 2020

View reviewed changes

undo changes to deprecated group tags

35cbba0

3b added 2 commits October 17, 2020 16:52

restore some old group names

5a2107c

add missing group to glVertexAttribPointerNV

bb3a7c2

Perksey reviewed Oct 18, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

working on some missing enum groups #431

working on some missing enum groups #431

3b commented Oct 4, 2020

Perksey commented Oct 4, 2020

3b commented Oct 14, 2020

Perksey left a comment

Perksey Oct 15, 2020

Perksey Oct 15, 2020

Perksey Oct 15, 2020

3b Oct 15, 2020

Perksey Oct 16, 2020

3b Oct 17, 2020

Perksey Oct 18, 2020

Perksey Oct 15, 2020

3b Oct 15, 2020

Perksey Oct 15, 2020

Perksey Oct 15, 2020

3b Oct 15, 2020

3b commented Oct 15, 2020

3b commented Oct 17, 2020

3b commented Oct 17, 2020

3b commented Oct 17, 2020

Perksey Oct 18, 2020

Perksey Oct 18, 2020

Perksey Oct 18, 2020

Perksey Oct 18, 2020

Perksey commented Oct 18, 2020

Perksey commented Oct 18, 2020

3b commented Oct 18, 2020

pdaniell-nv commented Oct 19, 2020

Perksey commented Oct 20, 2020

frederikja163 commented May 19, 2021

3b commented May 23, 2021

		<enum value="0x82D4" name="GL_VERTEX_ATTRIB_BINDING" group="GetVertexAttribPName"/>
		<enum value="0x82D5" name="GL_VERTEX_ATTRIB_RELATIVE_OFFSET" group="GetVertexAttribPName,VertexArrayPName"/>

working on some missing enum groups #431

Are you sure you want to change the base?

working on some missing enum groups #431

Conversation

3b commented Oct 4, 2020

Perksey commented Oct 4, 2020

3b commented Oct 14, 2020

Perksey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

3b commented Oct 15, 2020

3b commented Oct 17, 2020

3b commented Oct 17, 2020

3b commented Oct 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Perksey commented Oct 18, 2020

Perksey commented Oct 18, 2020

3b commented Oct 18, 2020

pdaniell-nv commented Oct 19, 2020

Perksey commented Oct 20, 2020

frederikja163 commented May 19, 2021

3b commented May 23, 2021