Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic arcface #452

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chingisooinar
Copy link
Contributor

Hello, I am working on Dynamic Arcface: https://arxiv.org/pdf/2010.05350.pdf. I implemented a unit test. However, I have some implementation concerns. Particularly, Dynamic Arcface seems to more of a wrapper than a separate DM loss. I would prefer implementing it as a Wrapper class but I would love to know what you think. Thank you!

@KevinMusgrave
Copy link
Owner

KevinMusgrave commented Jun 5, 2022

Sorry I haven't had a chance yet to look at this. I'm still interested though, so I'm re-opening. (Unless you really want it to be closed.)

@KevinMusgrave KevinMusgrave reopened this Jun 5, 2022
@chingisooinar
Copy link
Contributor Author

@KevinMusgrave I was not sure about the name I gave to it. I have recently found a work with the exact same name (Dyn-Arcface) (https://www.youtube.com/watch?v=Qa1WWYtYPE8). This algorithm, however, is more of a tech report, as far as I understand. So, I am not sure what to do with it.

@KevinMusgrave KevinMusgrave linked an issue Jun 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dynamic margin option to ArcFaceLoss
2 participants