Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #31318 - Never synced products show synced date #10994

Merged
merged 1 commit into from
May 15, 2024
Merged

Fixes #31318 - Never synced products show synced date #10994

merged 1 commit into from
May 15, 2024

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented May 14, 2024

What are the changes introduced in this pull request?

Never synced products show synced date in product list page.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Create a product.
  2. Create a repository.
  3. Go to Content > Products.
  4. The table will show a date/time for last synced column.

With this PR:

The table will show "Never synced" for products with repos that have never been synced.

@chris1984 chris1984 self-assigned this May 15, 2024
chris1984
chris1984 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, looks fine and works as expected in testing steps

@sjha4 sjha4 merged commit 19d4dd7 into Katello:master May 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees

@chris1984 chris1984

Labels
Ready for merge
Projects
None yet
Milestone
No milestone
2 participants
@sjha4 @chris1984