Fixes #35959 - prepare to use structured publisher for deb content #10420
Conversation
|
Issues: #35959 |
sbernhard
changed the title
|
@sbernhard : Is this part of a bigger RFE? For this PR is there a way to test this? Code LGTM as far as non-deb content goes but I am not sure how it impacts deb repos. |
To use this, we need to change the subscription-manager, too. We are working on it. |
sbernhard
force-pushed
the
deb_structured
branch
from
bbf8ecf
to
0fc209c
Compare
|
Together with candlepin/subscription-manager#3223 it works. Unfortunately, it still has one limitation: We need packages uploaded to pulp_deb to be added to some fall back component by default. |
sbernhard
force-pushed
the
deb_structured
branch
from
0fc209c
to
2a4a268
Compare
sbernhard
force-pushed
the
deb_structured
branch
from
2a4a268
to
151c89f
Compare
sbernhard
changed the title
| @@ -434,6 +434,23 @@ def format_arches | |||
| end | |||
| end | |||
|
|
|||
| def format_custom_content_path | |||
| path = custom_content_path | |||
| if content_type == ::Katello::Repository::DEB_TYPE && SETTINGS[:katello][:use_deb_structured_publisher] == true | |||
There was a problem hiding this comment.
Long term story: we want to get rid of this setting again.
We need this setting so that old sub-man works. If "all users" use the new sub-man (see candlepin/subscription-manager#3223 ) then we would remove this check setting check again. Additionally, we would remove to do a simple publish in pulp which would increase the performance a lot.
|
Is this ready to be merged? I'm curious what the testing steps would be from the debian side. After applying the sub-man patch and we sync a debian repo, what would we be looking for in the distribution path? |
|
@ianballou I think it is not quite ready to be merged, since we are still working on other building blocks to complete this story. @sbernhard Perhaps we can convert this to "draft PR" status until we are ready to add some testing instructions. |
|
Thanks for moving it to a draft! Mind pinging us when it's ready? |
| distributions.concat(' default') | ||
| end | ||
|
|
||
| super.merge({policy: policy, distributions: distributions}) |
There was a problem hiding this comment.
| super.merge({policy: policy, distributions: distributions}) | |
| super.merge({distributions: distributions}) |
This is a rebase error.
Co-authored-by: Bernhard Suttner <suttner@atix.de> from Katello#10420
quba42
force-pushed
the
deb_structured
branch
from
e926bbe
to
cc71e98
Compare
m-bucher
force-pushed
the
deb_structured
branch
from
1cbaafc
to
e4827b5
Compare
Co-authored-by: Bernhard Suttner <suttner@atix.de>
Should be added to: [PR] Fixes #35959 - Add structured APT content mode
…proxy This can be reverted once OR-4275 is fixed! https://atix.atlassian.net/browse/OR-4275
m-bucher
force-pushed
the
deb_structured
branch
from
e4827b5
to
0cdd0ac
Compare
Co-authored-by: Bernhard Suttner <suttner@atix.de> from Katello#10420
Co-authored-by: Bernhard Suttner <suttner@atix.de> from Katello#10420
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?