Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue-CLI / webpack documentation #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joestrouth1
Copy link

The readme describes adding a regex to an exclude statement in webpack's config in order to use this with vue-cli.

I'm not sure when things changed, but as of today there is no exclude node_modules statement in their config. They explicitly include src and test instead.

This PR addresses that by adding their current configuration, what needs to be changed to in order to get a successful build, and a brief description of what that's doing/why. I've left the old regex alongside in case someone is using another version.

@tony
Copy link

tony commented Jan 30, 2018

Thank you!

@Justineo
Copy link
Owner

Justineo commented Feb 1, 2018

Sorry guys, I've been overlooking this project for quite long time. The related project Vue-Awesome is being continuously updated. They are almost the same except for the built-in icon set. I think we can either:

  1. Switch to Vue-Awesome and just load Octicons as its icon data.
  2. or keep Vue-Octicon almost the same with Vue-Awesome.

And also, PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants