Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D SOM and examples #82

Open
wants to merge 407 commits into
base: master
Choose a base branch
from
Open

Conversation

StevenGuo42
Copy link

SOM with 3 dimensional map
examples: 3D color mapping, and mapping hand written digits to a 3D space

@JustGlowing
Copy link
Owner

hi @StevenGuo42, thanks for submitting this pull request. I'll have a look during the weekend.

@JustGlowing
Copy link
Owner

JustGlowing commented Sep 17, 2020

Dear @StevenGuo42,

I really appreciate your hard work but unfortunately I don't see a way to merge this pull request for the following reasons:

  • The feature implemented doesn't allow the library to solve new problems and adds a parameter that is hard to optimize.
  • It doubles the lines of code of the project and there are plenty of if-then statements to deal with specific cases. This decreases the maintainability of the code (and possibly the performances as there's an if-then in the main training loop).

There's definitely value in what you have done but I don't see it fitting well in the current shape of the repository. However, I would be happy to have an example of how to use a 3D som if you find a way to keep your work self contained in a notebook.

@StevenGuo42
Copy link
Author

Hello @JustGlowing
Thanks for the feedback. I got quite busy recently and that will take me a while to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale Pr/Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants