Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Xeus Impl #31

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Full Xeus Impl #31

wants to merge 18 commits into from

Conversation

spennihana
Copy link
Member

No description provided.

@SylvainCorlay
Copy link

woot!

@jasongrout
Copy link

+414 −4,153

Nice!!!

@spennihana
Copy link
Member Author

spennihana commented Mar 29, 2018

Took a little longer than expected since I combined this with an RInside experiment. Although, it looks like RInside is not yet ready for prime-time (ton of runtime issues that I won't enumerate here)... And so last mile effort is reverting the RInside bits.

Few more days now :)

Primary reason for this experiment was to get interrupts working; however, it seems that interrupts may be some time away still :( . I suppose we will live without them (on Windows, R will likely never see interrupts anyhow).

@jasongrout
Copy link

Does Xeus not support kernel interrupts?

@spennihana
Copy link
Member Author

spennihana commented Mar 29, 2018

Quote from @JohanMabille in the QuantStack/xeus gitter:

interrupt has not been implemented yet, I think it is part of the version 5.3 of the protocol while xeus implements only 5.1

Been down the road to get portable interrupts playing nicely with R (read: CRAN). It seems that there needs to be a guarantee about the state of the interpreter post-interrupt, so it seems unlikely to me that this would be solved in a generic way. Hopefully I am wrong.

@SylvainCorlay
Copy link

We should probably add a handler for interrupt_[request/reply], but most of the logic would be left to the implementation.

@SylvainCorlay
Copy link

Opened jupyter-xeus/xeus#56

@spennihana
Copy link
Member Author

Unfortunately, none of xeus, rinside, or rcpp will allow interrupts to occur from outside of R in a reliable way. The only way to get interrupts to work (even partially!) is to move the shell socket into the main R body. Not sure if this is possible to do in the xeus framework.

@spennihana
Copy link
Member Author

fyi, for windows interrupt: see issue #25 and PR #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants