Use opaque closure to fix ShardedForm #954
Open
+32
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashi
changed the title
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #954 +/- ##
=========================================
- Coverage 8.35% 8.35% -0.01%
=========================================
Files 26 26
Lines 3267 3269 +2
=========================================
Hits 273 273
- Misses 2994 2996 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I guess we have fixed the wrong answers. This branch causes an increase in runtime allocations. Do we want this despite the performance problem? @wsphillips |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wsphillips said that this branch was giving wrong answers when using Multithreading, but I don't have a reproducer.
Fixes #937