Recompile Invalidations #951
Open
+23
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How much of a difference does this make? |
|
Not making much difference to MOL discretization times, but that was <1% recomp anyway. What are the pathological cases this should fix? |
|
Symbolic arithmetic has some pathological cases. How much of a precompilation cost is this? |
|
This adds only a few seconds to precompile time, within 3 seconds |
|
Seems like there was an issue with the merge commit. @xtalax can you start this again and I'll merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of PrecompileTools to recompile invalidations