Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return rationals from linear_expansion and solve_for #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return rationals from linear_expansion and solve_for #1136

wants to merge 1 commit into from

Conversation

hersle
Copy link

@hersle hersle commented May 9, 2024

This fixes #524.

Does it break anything else?
I am not able to run all tests locally, as ] test fails with a bunch of warnings, with or without my changes 馃槙

YingboMa
YingboMa requested changes May 9, 2024
View reviewed changes
Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to post-process a and b so that +- n//1 becomes just +- n.

@hersle
Copy link
Author

hersle commented May 10, 2024

Where exactly do you mean?
Do you mean that linear_expansion should return fractions for a and b if they are not divisible, and integers if they are divisible? Or the same with the results from solve_for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YingboMa YingboMa YingboMa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

solve_for gives Float64 instead of rational solutions
2 participants
@hersle @YingboMa