Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming Sphere1 --> Circle, and add #1203

Closed
dehann opened this issue Mar 11, 2021 · 0 comments · Fixed by #1209
Closed

Fix naming Sphere1 --> Circle, and add #1203

dehann opened this issue Mar 11, 2021 · 0 comments · Fixed by #1209
Labels
API bug deprecation manifolds refactoring standardization variableType Renamed from softtype
Projects
Roadmap to V1.0
Milestone
v0.22.0

Comments

@dehann
Copy link
Member

dehann commented Mar 11, 2021 •
edited

  • Sphere1 is n+1 dimensional, as in (x,y) for disk.
  • Circle is 1 dimensional, as in theta angle for a circle.

Result should be two types standardized with Manifolds.jl

  • Circle
  • Sphere{N}

xref
@dehann dehann added this to the v0.22.0 milestone Mar 11, 2021
@dehann dehann added this to Improvements in Roadmap to V1.0 via automation Mar 11, 2021
@dehann dehann mentioned this issue Mar 26, 2021
Merged
@dehann dehann closed this as completed Mar 26, 2021
Roadmap to V1.0 automation moved this from Improvements to Completed Mar 26, 2021
@dehann dehann mentioned this issue Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API bug deprecation manifolds refactoring standardization variableType Renamed from softtype
Projects
Roadmap to V1.0
  
Completed
Milestone
v0.22.0
Development

Successfully merging a pull request may close this issue.

add dep Manifolds.jl, towards new defs JuliaRobotics/IncrementalInference.jl
1 participant
@dehann