Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate AbstractRelativeRoots shuffleX, preserve partial #1072

Closed
dehann opened this issue Dec 28, 2020 · 0 comments · Fixed by #1075
Closed

Deprecate AbstractRelativeRoots shuffleX, preserve partial #1072

dehann opened this issue Dec 28, 2020 · 0 comments · Fixed by #1075
Labels
deprecation factors inference standardization types
Projects
Roadmap to V1.0
Milestone
v0.19.0

Comments

@dehann
Copy link
Member

dehann commented Dec 28, 2020 •
edited

All factor cases of .partial or low rank factors should use AbstractRelativeMinimize instead. Unnecessary, never added much value, also not compatible with JuliaRobotics/RoME.jl#244

Partial behavior needs to be kept, at least in cases where its easy to sub-select elements
@dehann dehann added this to the v0.19.0 milestone Dec 28, 2020
@dehann dehann added this to Improvements in Roadmap to V1.0 via automation Dec 28, 2020
This was referenced Dec 28, 2020
Closed
Merged
@dehann dehann changed the title Deprecate AbstractRelativeRoots shuffleX Deprecate AbstractRelativeRoots shuffleX, preserve partial Dec 28, 2020
dehann added a commit that referenced this issue Dec 28, 2020
@dehann
drop shuffleX, depr (::ccw)(x...), close #1072
77ea4f9
@dehann dehann mentioned this issue Dec 28, 2020
Merged
Roadmap to V1.0 automation moved this from Improvements to Completed Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation factors inference standardization types
Projects
Roadmap to V1.0
  
Completed
Milestone
v0.19.0
Development

Successfully merging a pull request may close this issue.

drop shuffleX, depr (::ccw)(x...) JuliaRobotics/IncrementalInference.jl
1 participant
@dehann