Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making PGFPlotsX use deterministic series IDs #4932

Merged
merged 2 commits into from May 13, 2024

Conversation

ajdunlap
Copy link
Contributor

@ajdunlap ajdunlap commented May 6, 2024

Description

This is a first attempt at addressing #4927 . One downside I can see is that this may impact thread-safety. It also may be a bit slower if there are many many series, but it seems like there would have to be really a lot of series for the maximum call to take a significant amount of time.

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (fa65e7d) to head (2b89cbe).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4932      +/-   ##
==========================================
- Coverage   89.77%   89.69%   -0.08%     
==========================================
  Files          40       40              
  Lines        8780     8792      +12     
==========================================
+ Hits         7882     7886       +4     
- Misses        898      906       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeastyBlacksmith
Copy link
Member

BeastyBlacksmith commented May 7, 2024

The problem I see here is, that when you have multiple such outputs in a larger tex-file you really want the ids to be unique to the whole document and not just to a single plot, or a particular process.

@ajdunlap
Copy link
Contributor Author

ajdunlap commented May 7, 2024

I just tried a test file with two identical PGFPlots with identical "name path" values and it compiled correctly and didn't complain about the repeated "name path" values. Of course it also doesn't complain when there are repeated name path values in the same plot, but then of course the output is not correct. But if it is essential to have unique name paths even through multiple plots in the same document, then indeed something more complicated is required here.

Copy link
Member

@BeastyBlacksmith BeastyBlacksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this then, I think this should be the only use of UUIDs in the codebase and thus we can remove this dependency then.
Can you also open a PR with this against the v2 branch?

@BeastyBlacksmith BeastyBlacksmith merged commit 41a06a3 into JuliaPlots:master May 13, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants