Add apply_step! option for Newton method #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using `method=:newton` with `linesearch=LineSearches.Static()` (the default linesearch), an additional argument `project_region!` (default value `(x)->(nothing)`) can be used to define a function to modify the proposed new `x` value after each Newton iteration. For example, `project_region! = (x) -> (x .= max.(x, 1e-80))` will enforce a constraint `x[i] >= 1e-80`.
If `method = :newton` and `linesearch=LineSearches.Static()` (the default),
an additional argument `apply_step!` (default value `(x, x_old, newton_step)->(x .= x_old .+ newton_step)`)
can be used to define a function to modify the proposed new `x` value after the Newton iteration.
eg
`apply_step! = (x, x_old, newton_step)->(x .= x_old .+ newton_step; x .= max.(x, 1e-80))`
will enforce a constraint `x[i] >= 1e-80`.
sjdaines
changed the title
|
+1 for this - it would be fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using
method = :newtonwithlinesearch=LineSearches.Static(), adds an option to supply a function to modify Newton steps eg to restrict step length or to restrict to a region. This makes it possible to include problem-specific constraints (eg from a physical or chemical system) to increase robustness.Adds an additional argument
apply_step!(default value(x, x_old, newton_step)->(x .= x_old .+ newton_step)) todefine the function used to update the
xvalue after the Newton iteration.For example,
apply_step! = (x, x_old, newton_step)->(x .= x_old .+ newton_step; x .= max.(x, 1e-80))will enforce a constraint
x[i] >= 1e-80to maintain positive concentrations for a chemical kinetics problem.