Multicomponents #851
Open
Multicomponents #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epolack
force-pushed
the
multicomponents
branch
4 times, most recently
from
68289be
to
e309215
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
epolack
force-pushed
the
multicomponents
branch
13 times, most recently
from
4b3d2f4
to
861982d
Compare
epolack
force-pushed
the
multicomponents
branch
7 times, most recently
from
2a0c5b9
to
1683462
Compare
|
@mfherbst Could you give me some feedback on this PR? It takes quite some time to keep it up to date with the master branch. |
Understood. I'm pretty busy right now, but I'll do it as soon as I can. |
|
Sure, Thanks! I just wanted to make sure you had it on your radar :) |
epolack
force-pushed
the
multicomponents
branch
8 times, most recently
from
1345936
to
6434a0c
Compare
epolack
force-pushed
the
multicomponents
branch
8 times, most recently
from
c78f7f7
to
748beed
Compare
epolack
force-pushed
the
multicomponents
branch
from
748beed
to
6ec2f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API question to settle
TermKinetic.kinetic_energies,RealSpaceMultiplication.potentialto prevent loops on the components; but maybe in a second time (i.e., future PR). Implementing one at a time needed generalisations?It was what was done for the preconditioner before (e.g., hash 9869eb5)
Remaining points
∅
Future PR
BlochWavesBase.showmethods); maybe report toψk::BlochWave.