Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge InteractBase into Interact #367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

merge InteractBase into Interact #367

wants to merge 2 commits into from

Conversation

piever
Copy link
Collaborator

@piever piever commented May 14, 2020

This merges InteractBase back into Interact. I've removed the Manifest.toml from the docs because it was still trying to install InteractBase, not sure why.

cc: @shashi @travigd

Note: the build step downloads files from https://github.com/piever/InteractResources. Some are standard js, css things, and there are a couple of custom made css from bulma (to adjust styling of rangeslider and confine css in jupyter notebook), that are compiled using this scss https://github.com/piever/InteractBulma.jl/tree/master/assets and this package https://github.com/piever/Sass.jl.

I imagine InteractBulma (useful to add more Bulma styles) can be moved to JuliaGizmos, and we may consider a more standard way of distributing those files.

@twavv
Copy link
Member

twavv commented May 14, 2020

TYSM!

I'll check this out later. :^)

Ultimately I just want to update this in tandem with WebIO/next. I have some thoughts on a simpler asset pipeline as well (using GitHub assets). Ideally we'd use Artifacts.toml but I'm not sure how well that would work with the kinds of assets we'd be downloading. 🤷‍♀️

@piever
Copy link
Collaborator Author

piever commented Jan 25, 2021

Should we go ahead with this? I'm realizing that I will not have much time to devote to Interact development in the foreseeable future, so for me it would make a lot of sense to merge the repo in my own github account (that is, piever/InteractBase.jl) here.

I guess that removes one extra hoop to new contributors (they don't have to figure out that the code lives somewhere else).

@twavv
Copy link
Member

twavv commented Jan 25, 2021

I'll leave it up to you. I'm also not having much time these days.

@hhaensel
Copy link

Just a comment: If you're doing this (which would certainly be nice), consider bumping the deps, to the latest versions ... 😉
Particularly, Knockout (0.2.4) and Observables (0.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants