Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docfixes #332

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Docfixes #332

wants to merge 3 commits into from

Conversation

kersulis
Copy link

Tidying up grammar and fixing a couple typos. I think I fixed the jupyter labextension installation code, but the extension itself wasn't installing correctly on my laptop.

@piever
Copy link
Collaborator

piever commented Aug 16, 2019

Thanks a lot!
Pinging @travigd to make sure the installation instruction are correct for jupyter-lab.

The failure seems unrelated (again problems with downloading gitcdn, I'll probably switch to jsdelivr soon for downloading the customized css files).

One nitpick: the tutorial notebook in doc/notebooks/tutorial.ipynb is generated from the tutorial.jl file using Literate (same as the markdown file in the docs, but that's automated in the pipeline here). Would you mind running the Literate.notebook command again to keep the notebook and the docs in sync? I unfortunately am no longer 100% sure what are the correct keyword arguments to be passed to Literate.notebook but it should be the same as here with execute=false.

@twavv
Copy link
Member

twavv commented Aug 16, 2019

It's just WebIO.install_jupyter_labextension() for lab (and WebIO.install_jupyter_nbextension() for classic notebook). Where did you get the link stuff from (I just want to make sure that it's not in some docs somewhere that I missed)? Please also link to the WebIO docs (https://juliagizmos.github.io/WebIO.jl/latest/providers/ijulia/) because there are a bunch of pitfalls concerning installing with JupyterLab.

Edit: oh hi Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants