Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat) #3397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request sets the compat entry for the Statistics package to 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@github-actions github-actions bot force-pushed the compathelper/new_version/2023-10-29-00-04-53-630-04136909440 branch from 9a8d4c0 to d390dde Compare October 29, 2023 00:05
@bkamins
Copy link
Member

bkamins commented Oct 29, 2023

@nalimilan do you know if:

  1. should this be merged as is.
  2. we should make a release with this change? (to ensure that DataFrames.jl on some versions of Julia do not error?)

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Oct 29, 2023
@bkamins bkamins added this to the patch milestone Oct 29, 2023
@nalimilan
Copy link
Member

I think this is only needed to avoid breakage when Statistics 2.0 is released, so there's no hurry. Better merge this before the next release though (that upper bound has been added automatically to existing releases in the registry).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants