New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #628 by enabling opt-in to nullable scopes #644

Open

grantholle wants to merge 4 commits into JosephSilber:master from grantholle:loose-scoping

Contributor

grantholle commented Dec 15, 2023

This tries to rectify the aftermath of #608 by allowing you to opt-in to allowing scope to be null.

To enable pre 1.0.1 functionality, call allowNullScope() when setting the scope.

Bouncer::scope()
    ->to(1)
    ->allowNullScope();

grantholle added 4 commits

December 15, 2023 12:23


          Fix JosephSilber#628 by enabling opt-in to nullable scopes

c13fdcd


          Remove unnecessary conditional

eedfbae


          Remove unfinished function

5e5263c


          Fix failing test

c0953be

Contributor Author

grantholle commented Dec 15, 2023

I don't know if I solved the failing test the right way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment