Merge pull request #88 from sberrevoets/master

Turn on warning for implicitly referencing self
JonasGessner · Mar 15, 2018 · 26457bf · 26457bf
2 parents 8535854 + fc8746b
commit 26457bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/JGProgressHUD.xcodeproj/project.pbxproj b/JGProgressHUD.xcodeproj/project.pbxproj
@@ -561,6 +561,7 @@
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
@@ -610,6 +611,7 @@
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;

diff --git a/JGProgressHUD/JGProgressHUD/JGProgressHUD.m b/JGProgressHUD/JGProgressHUD/JGProgressHUD.m
@@ -361,8 +361,8 @@ - (void)layoutHUD {
 
     [UIView performWithoutAnimation:^{
         self.indicatorView.frame = indicatorFrame;
-        _textLabel.frame = JGProgressHUD_CGRectIntegral(labelFrame);
-        _detailTextLabel.frame = JGProgressHUD_CGRectIntegral(detailFrame);
+        self->_textLabel.frame = JGProgressHUD_CGRectIntegral(labelFrame);
+        self->_detailTextLabel.frame = JGProgressHUD_CGRectIntegral(detailFrame);
     }];
 
     [self setHUDViewFrameCenterWithSize:size insetViewFrame:insetFrame];
@@ -860,8 +860,8 @@ - (void)setIndicatorView:(JGProgressHUDIndicatorView *)indicatorView {
     }
 
     [UIView performWithoutAnimation:^{
-        [_indicatorView removeFromSuperview];
-        _indicatorView = indicatorView;
+        [self->_indicatorView removeFromSuperview];
+        self->_indicatorView = indicatorView;
 
         if (self.indicatorView != nil) {
             [self.indicatorView setUpForHUDStyle:self.style vibrancyEnabled:self.vibrancyEnabled];