Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-1036: Onnx Example notebooks #14234

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DevinTDHa
Copy link
Member

Description

This PR fixes all issues with the ONNX example notebooks and adjusts the documentation of the annotators if necessary.

The following issues have been fixed:

  • keras.engine can't be imported
    • Udated transformers version to 4.34.1
  • ONNX model version issues: Unsupported model IR version: 10, max supported IR version: 9
    • pin onnx version to onnx==1.14.0
  • Breeze issues: java.lang.NoSuchMethodError: 'breeze.storage.Zero breeze.storage.Zero$.FloatZero()
    • requires spark 3.4, added in the notebooks and mentions in the documentation
  • Colab button links
  • various minor typos that caused errors

Motivation and Context

Users should be able to use these export notebooks without any issues.

How Has This Been Tested?

Run in Colab, all notebooks run without issues.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant