This repository has been archived by the owner on Oct 30, 2020. It is now read-only.
Add orderAlphabetically option #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obi-Dann
reviewed
Oct 12, 2017
src/cssModuleToInterface.js
Outdated
| @@ -6,13 +6,15 @@ const filenameToInterfaceName = (filename) => { | |||
| .replace(/\W+(\w)/g, (_, c) => c.toUpperCase()); | |||
| }; | |||
|
|
|||
| const cssModuleToTypescriptInterfaceProperties = (cssModuleKeys, indent = ' ') => { | |||
| const cssModuleToTypescriptInterfaceProperties = (cssModuleKeys, orderAlphabetically, indent = ' ') => { | |||
| cssModuleKeys = orderAlphabetically ? cssModuleKeys.sort() : cssModuleKeys | |||
There was a problem hiding this comment.
sort mutates the current array
var arr = ['b', 'a'];
arr.sort(); // (2) ["a", "b"]
console.log(arr); // (2) ["a", "b"]
what do you think about using slice or spread to avoid mutation of the incoming parameter?
You may also consider moving the sorting logic into a helper function so you DRY
FinestV
force-pushed
the
master
branch
2 times, most recently
from
62ce71e
to
3137d46
Compare
Use this option to sort the module key strings alphabetically
|
@timse what do we need to do get the PR merged ? It's a bit alarming that there were no pull requests merged since 2017. Are you still maintaining the project ? |
|
seems like a No to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found when using this loader the .d.ts files would change ordering between commits.
This adds an orderAlphabetically option to ensure the ordering remains consistent